Introduce custom QueryClient #468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-sachs
force-pushed
the
psachs/v2-query-client
branch
2 times, most recently
from
7fdd7f9 to
3647d72
Compare
paul-sachs
changed the title
timostamm
reviewed
Oct 29, 2024
packages/connect-query-core/src/create-infinite-query-options.ts
Outdated
Show resolved
Hide resolved
paul-sachs
force-pushed
the
psachs/v2-query-client
branch
from
7e10f7c to
8bc29eb
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/v2-query-client
branch
from
a427255 to
3d5adc5
Compare
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/v2-query-client
branch
from
3d5adc5 to
38ca830
Compare
paul-sachs
changed the title
Signed-off-by: Paul Sachs <11449728+paul-sachs@users.noreply.github.com>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
…nit shape Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
|
@timostamm Moved in suggested changes from #518 into this PR instead. It does feel a lot better to have it integrated into the query client |
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
added a commit
that referenced
this pull request
May 20, 2025
By adding DataTag annotations to the ConnectQueryKey, QueryClient methods can now infer the return type when calling things like `getQueryData` or `invalidateQueries`. This is at least a partial alternative to #468 which provides better inference abilities while keeping our api surface smaller. There may still be value down the line with very well defined query client methods but I suspect this change covers 90% of the current use cases. --------- Signed-off-by: Paul Sachs <psachs@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new QueryClient introduces typesafe APIs to all the relevant queryClient APIs that you'd want to use.
This change can help alleviate the following issues: #467 #390 #391